Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide full search results on result-batch plugin mount event #666

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

tiberio-baptista
Copy link
Collaborator

The webapp does not provide the full search results on the result-selection-ready event.

This PR fixes this issue by providing both the search results and the search results that were selected via the UI, instead of only providing the selected entries.

Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem solid, and serve a good purpose. As the web UI plugin framework is not currently covered by semver stability guarantees, the upcoming version will be a patch release, 3.3.2. I will leave a warning in the release notes that the API for web UI result-batch plugins has changed.

I also filed an issue at generator-dicoogle-webplugin so that scaffolding webplugins consider this change in the future.

@Enet4 Enet4 merged commit 7ae0e4d into bioinformatics-ua:dev Sep 25, 2023
3 checks passed
@Enet4 Enet4 deleted the imp/result-event-emit branch September 25, 2023 16:06
@Enet4 Enet4 changed the title Provide search results on search-result plugin mount event Provide full search results on result-batch plugin mount event Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement webapp webui-breaking-change Breaking change to the Web UI plugin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants